Skip to content

Run tests on release builds #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2016
Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Oct 31, 2016

This makes cargo test test the appropriate release/debug bindgen binary and extends Travis CI testing to also test release builds.

r? @emilio

@emilio
Copy link
Contributor

emilio commented Oct 31, 2016

Looks good to me, though travis doesn't agree... Let's try again...
@bors-servo r+

@bors-servo
Copy link

📌 Commit 5c08d9b has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 5c08d9b with merge 6fabfac...

bors-servo pushed a commit that referenced this pull request Oct 31, 2016
Run tests on release builds

This makes `cargo test` test the appropriate release/debug bindgen binary and extends Travis CI testing to also test release builds.

r? @emilio
@fitzgen
Copy link
Member Author

fitzgen commented Oct 31, 2016

Interesting...

thread 'run_bindgen_tests' panicked at '/home/travis/build/servo/rust-bindgen/target/release/bindgen is not a file! Build bindgen before running tests.', tests/tests.rs:74

@bors-servo
Copy link

💔 Test failed - status-travis

@fitzgen
Copy link
Member Author

fitzgen commented Oct 31, 2016

I think I need to if cfg!(debug_assertions)

@fitzgen
Copy link
Member Author

fitzgen commented Oct 31, 2016

@bors-servo retry

@fitzgen
Copy link
Member Author

fitzgen commented Oct 31, 2016

@bors-servo try

@emilio
Copy link
Contributor

emilio commented Oct 31, 2016

@bors-servo r+

@bors-servo
Copy link

📌 Commit bc99e3f has been approved by emilio

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit bc99e3f into rust-lang:master Oct 31, 2016
bors-servo pushed a commit that referenced this pull request Oct 31, 2016
Run tests on release builds

This makes `cargo test` test the appropriate release/debug bindgen binary and extends Travis CI testing to also test release builds.

r? @emilio
@fitzgen fitzgen deleted the release-tests branch October 31, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants